Re: [PATCH net-next v4 03/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper

From: Menglong Dong
Date: Sat Oct 05 2024 - 23:51:58 EST


On Sat, Oct 5, 2024 at 12:43 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Tue, 1 Oct 2024 15:32:16 +0800 Menglong Dong wrote:
> > -static inline bool skb_vlan_inet_prepare(struct sk_buff *skb,
> > - bool inner_proto_inherit)
> > +static inline enum skb_drop_reason
> > +skb_vlan_inet_prepare_reason(struct sk_buff *skb, bool inner_proto_inherit)
>
> this only has 5 callers, please convert them to expect a drop
> reason to be returned instead of adding a compatibility wrapper

Okay!

> --
> pw-bot: cr