Re: [PATCH] arm64: dts: qcom: sc7280: enable venus node

[Krzysztof Kozlowski]

On 04/10/2024 12:52, Vedang Nagar wrote:
> Enable the venus node on Qualcomm sc7280. It was made disabled
> earlier to avoid bootup crash, which is fixed now with [1].
> 
> [1]
> https://lore.kernel.org/linux-media/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@xxxxxxxxxxxxx/
> 
> Signed-off-by: Vedang Nagar <quic_vnagar@xxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 3d8410683402fd4c03c5c2951721938fff20fc77..59dafbeeab1dfd6e1b021335ba1b04767d6c24e5 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -4288,8 +4288,6 @@ venus: video-codec@aa00000 {
>  			iommus = <&apps_smmu 0x2180 0x20>;
>  			memory-region = <&video_mem>;
>  
> -			status = "disabled";

That's just wrong. It's already enabled in other places which makes them
redundant, so patch is incomplete.

But what is more important: this is just not correct, IMO. The node
looks incomplete. You cannot enable incomplete nodes. Please carefully
read how DTS files are being constructed/used.

Best regards,
Krzysztof