Re: [PATCHv4 1/1] platform/x86: dell-sysman: add support for alienware products

From: Hans de Goede
Date: Sun Oct 06 2024 - 06:46:02 EST


Hi,

On 6-Oct-24 12:43 PM, Hans de Goede wrote:
> Hi,
>
> On 4-Oct-24 5:27 PM, Crag Wang wrote:
>> Alienware supports firmware-attributes and has its own OEM string.
>>
>> Signed-off-by: Crag Wang <crag_wang@xxxxxxxx>
>
> Thank you for your patch/series, I've applied this patch
> (series) to my review-hans branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>
> Note it will show up in the pdx86 review-hans branch once I've
> pushed my local branch there, which might take a while.
>
> I will include this patch in my next fixes pull-req to Linus
> for the current kernel development cycle.

Running checkpatch after applying show:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Crag Wang <crag0715@xxxxxxxxx>' != 'Signed-off-by: Crag Wang <crag_wang@xxxxxxxx>'

I have fixed this by running:

git commit --amend --author="Crag Wang <crag_wang@xxxxxxxx>"

So that things match now. Next time please try to use your Dell
email for submitting the patches instead of gmail.

Regards,

Hans