Re: [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF
From: Bryan O'Donoghue
Date: Sun Oct 06 2024 - 07:21:33 EST
On 05/10/2024 15:41, Jonathan Marek wrote:
This line is overwriting the result of the above switch-case.
This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop.
Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>
---
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
index a747baa297849..c37dede62e12c 100644
--- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
+++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
@@ -432,7 +432,6 @@ static int qcom_pmic_typec_port_get_cc(struct tcpc_dev *tcpc,
val = TYPEC_CC_RP_DEF;
break;
}
- val = TYPEC_CC_RP_DEF;
}
if (misc & CC_ORIENTATION)
Acked-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>