Re: [PATCH v2 3/4] iio: adc: Add support for the GE HealthCare PMC ADC

[Jonathan Cameron]

On Thu, 3 Oct 2024 08:39:54 -0500
David Lechner <dlechner@xxxxxxxxxxxx> wrote:

> On 10/3/24 6:46 AM, Herve Codina wrote:
> > The GE HealthCare PMC Analog to Digital Converter (ADC) is a 16-Channel
> > (voltage and current), 16-Bit ADC with an I2C Interface.
> > 
> > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
> > ---  
> 
> ...
> 
> 
> > +
> > +static int pmc_adc_probe(struct i2c_client *client)
> > +{
> > +	struct iio_dev *indio_dev;
> > +	struct pmc_adc *pmc_adc;
> > +	struct clk *clk;
> > +	s32 val;
> > +	int ret;
> > +
> > +	ret = devm_regulator_bulk_get_enable(&client->dev, ARRAY_SIZE(pmc_adc_regulator_names),
> > +					     pmc_adc_regulator_names);
> > +	if (ret)
> > +		return dev_err_probe(&client->dev, ret, "Failed to get regulators\n");
> > +
> > +	clk = devm_clk_get_optional_enabled(&client->dev, "osc");
> > +	if (IS_ERR(clk))
> > +		return dev_err_probe(&client->dev, PTR_ERR(clk), "Failed to get osc clock\n");
> > +
> > +	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*pmc_adc));
> > +	if (!indio_dev)
> > +		return -ENOMEM;
> > +
> > +	pmc_adc = iio_priv(indio_dev);
> > +	pmc_adc->client = client;
> > +
> > +	val = i2c_smbus_read_byte_data(pmc_adc->client, PMC_ADC_CMD_REQUEST_PROTOCOL_VERSION);
> > +	if (val < 0)
> > +		return dev_err_probe(&client->dev, val, "Failed to get protocol version\n");
> > +
> > +	if (val != 0x01)
> > +		return dev_err_probe(&client->dev, -EINVAL,
> > +				     "Unsupported protocol version 0x%02x\n", val);
> > +
> > +	indio_dev->name = "pmc_adc";
> > +	indio_dev->info = &pmc_adc_info;
> > +	indio_dev->channels = pmc_adc_channels;
> > +	indio_dev->num_channels = ARRAY_SIZE(pmc_adc_channels);  
> 
> I don't think the core code actually checks this, but for
> correctness we should add:
> 
> 	indio_dev->modes = INDIO_DIRECT_MODE;
True.  This is a bit of an oddity of history :(
Maybe at somepoint we'll just drop this but for now it should be there.

Given everything else looks good I've added that whilst
applying the series.  Applied to the togreg branch of iio.git and
pushed out as testing for 0-day to poke at it.

Thanks,

Jonathan


> 
> > +
> > +	return devm_iio_device_register(&client->dev, indio_dev);
> > +}
> > +  
> 
> With that...
> 
> Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>
>