Re: [PATCH v3 0/9] iio: light: veml6030: fix issues and add support for veml6035

From: Jonathan Cameron
Date: Sun Oct 06 2024 - 10:10:43 EST


On Tue, 01 Oct 2024 22:21:13 +0200
Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote:

> This series updates the driver for the veml6030 ALS and adds support for
> the veml6035, which shares most of its functionality with the former.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Nice series.

Applied to the togreg branch of iio.git and pushed out initially as
testing for 0-day to take a look at it.

thanks

Jonathan

> ---
> Changes in v3:
> - drop applied patch [1/10] (fixes-togreg).
> - Fix indentation of the vdd-supply property and make it required.
> - Fix formatting (double space).
> - Fix array formatting (space after {, space before }).
> - Move action to hw_init function and add dev as an argument.
> - Link to v2: https://lore.kernel.org/r/20240923-veml6035-v2-0-58c72a0df31c@xxxxxxxxx
>
> Changes in v2:
> - Rebase to iio/testing, dropping applied patches [1/7], [4/7].
> - Drop [3/7] (applied to iio/fixes-togreg).
> - Add patch to use dev_err_probe() in probe error paths.
> - Add patch to use read_avail() for available attributes.
> - Add patches to use to support a regulator.
> - Add patch to ensure that the device is powered off in error paths
> after powering it on.
> - Add patch to drop processed values from the WHITE channel.
> - Use fsleep() instead of usleep_range() in veml6030_als_pwr_on()
> - Link to v1: https://lore.kernel.org/r/20240913-veml6035-v1-0-0b09c0c90418@xxxxxxxxx
>
> ---
> Javier Carrasco (9):
> iio: light: veml6030: add set up delay after any power on sequence
> iio: light: veml6030: use dev_err_probe()
> dt-bindings: iio: light: veml6030: add vdd-supply property
> iio: light: veml6030: add support for a regulator
> iio: light: veml6030: use read_avail() for available attributes
> iio: light: veml6030: drop processed info for white channel
> iio: light: veml6030: power off device in probe error paths
> dt-bindings: iio: light: veml6030: add veml6035
> iio: light: veml6030: add support for veml6035
>
> .../bindings/iio/light/vishay,veml6030.yaml | 44 +-
> drivers/iio/light/Kconfig | 4 +-
> drivers/iio/light/veml6030.c | 464 ++++++++++++++++-----
> 3 files changed, 387 insertions(+), 125 deletions(-)
> ---
> base-commit: 19332fe4bd4659b2e3988f17b4d5dc59a86c266d
> change-id: 20240903-veml6035-7a91bc088c6f
>
> Best regards,