Re: [PATCH] selftests: make kselftest-clean remove libynl outputs

From: Muhammad Usama Anjum
Date: Sun Oct 06 2024 - 13:41:54 EST


On 10/6/24 2:56 AM, Greg Thelen wrote:
> Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
> for devmem TCP") kselftest-all creates additional outputs that
> kselftest-clean does not cleanup:
> $ make defconfig
> $ make kselftest-all
> $ make kselftest-clean
> $ git clean -ndxf | grep tools/net
> Would remove tools/net/ynl/lib/__pycache__/
> Would remove tools/net/ynl/lib/ynl.a
> Would remove tools/net/ynl/lib/ynl.d
> Would remove tools/net/ynl/lib/ynl.o
>
> Make kselftest-clean remove the newly added net/ynl outputs.
>
> Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP")
> Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx>
> ---
> tools/testing/selftests/net/ynl.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/net/ynl.mk b/tools/testing/selftests/net/ynl.mk
> index 59cb26cf3f73..1ef24119def0 100644
> --- a/tools/testing/selftests/net/ynl.mk
> +++ b/tools/testing/selftests/net/ynl.mk
> @@ -19,3 +19,7 @@ $(YNL_OUTPUTS): CFLAGS += \
> $(OUTPUT)/libynl.a:
> $(Q)$(MAKE) -C $(top_srcdir)/tools/net/ynl GENS="$(YNL_GENS)" libynl.a
> $(Q)cp $(top_srcdir)/tools/net/ynl/libynl.a $(OUTPUT)/libynl.a
> +
> +EXTRA_CLEAN += \
> + $(top_srcdir)/tools/net/ynl/lib/__pycache__ \
> + $(top_srcdir)/tools/net/ynl/lib/*.[ado]
Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>

--
BR,
Muhammad Usama Anjum