Re: [PATCH] bus: mhi: host: free buffer on error in mhi_alloc_bhie_table
From: Manivannan Sadhasivam
Date: Sun Oct 06 2024 - 14:05:58 EST
On Wed, Feb 07, 2024 at 09:51:36AM +0300, Fedor Pchelkin wrote:
> img_info->mhi_buf should be freed on error path in mhi_alloc_bhie_table().
> This error case is rare but still needs to be fixed.
>
> Found by Linux Verification Center (linuxtesting.org).
>
> Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
> Signed-off-by: Fedor Pchelkin <pchelkin@xxxxxxxxx>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
- Mani
> ---
> drivers/bus/mhi/host/boot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
> index edc0ec5a0933..738dcd11b66f 100644
> --- a/drivers/bus/mhi/host/boot.c
> +++ b/drivers/bus/mhi/host/boot.c
> @@ -357,6 +357,7 @@ int mhi_alloc_bhie_table(struct mhi_controller *mhi_cntrl,
> for (--i, --mhi_buf; i >= 0; i--, mhi_buf--)
> dma_free_coherent(mhi_cntrl->cntrl_dev, mhi_buf->len,
> mhi_buf->buf, mhi_buf->dma_addr);
> + kfree(img_info->mhi_buf);
>
> error_alloc_mhi_buf:
> kfree(img_info);
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்