Re: [PATCH v4 2/2] dt-bindings: mtd: davinci: convert to yaml

[Marcus Folkesson]

On Mon, Oct 07, 2024 at 08:07:27AM +0200, Krzysztof Kozlowski wrote:
> On Sun, Oct 06, 2024 at 03:05:47PM +0200, Marcus Folkesson wrote:
> > +  ti,davinci-nand-use-bbt:
> > +    type: boolean
> > +    description:
> > +      Use flash based bad block table support. OOB identifier is saved in OOB
> > +      area.
> > +    deprecated: true
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - ti,davinci-chipselect
> > +
> > +additionalProperties: true
> 
> That's a final device schema, this cannot be true. Why you are doing
> this entirely different than all other bindings?

From my understanding, additionalProperties is to indicate that the
schema could contain properties that were not explicit listed here but
inherited from e.g. nand-controller.yaml.

Obviously that is not the case.
Could you please give me some guidance?

> 
> You wrote in changelog, that you "silent the errors". Sorry, but that's
> a no go. You are not suppose to silent them, but FIX THEM.
> 
> 
> > +
> > +examples:
> > +  - |
> > +    nand-controller@2000000 {
> > +      compatible = "ti,davinci-nand";
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +
> > +      reg = <0 0x02000000>;
> 
> Keep order like in DTS coding style.
> 
> Best regards,
> Krzysztof
> 

Best regards,
Marcus Folkesson

Attachment: signature.asc
Description: PGP signature