Re: [PATCH] sched/deadline: Use hrtick_enabled_dl() before start_hrtick_dl()

From: Juri Lelli
Date: Mon Oct 07 2024 - 03:15:27 EST


Hi Phil,

On 04/10/24 08:37, Phil Auld wrote:
> The deadline server code moved one of the start_hrtick_dl() calls
> but dropped the dl specific hrtick_enabled check. This causes hrticks
> to get armed even when sched_feat(HRTICK_DL) is false. Fix it.
>
> Fixes: 63ba8422f876 ("sched/deadline: Introduce deadline servers")
> Signed-off-by: Phil Auld <pauld@xxxxxxxxxx>
> Cc: Juri Lelli <juri.lelli@xxxxxxxxxx>
> Cc: Valentin Schneider <vschneid@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>

Indeed. Good catch!

Acked-by: Juri Lelli <juri.lelli@xxxxxxxxxx>

Best,
Juri