Re: [RESEND PATCH v2] arm64: dts: qcom: sa8775p: Populate additional UART DT nodes

[Dmitry Baryshkov]

On October 7, 2024 9:06:52 AM GMT+03:00, Viken Dadhaniya <quic_vdadhani@xxxxxxxxxxx> wrote:
>
>
>On 10/7/2024 2:26 AM, Dmitry Baryshkov wrote:
>> On Mon, Sep 30, 2024 at 02:25:33PM GMT, Viken Dadhaniya wrote:
>>> Currently, UART configuration is populated for few
>>> SEs(Serial engine) only in sa8775p DTSI file.
>>> 
>>> Populate UART configurations of remaining SEs for sa8775p soc.
>> 
>> I think this is a long standing tradition of adding UART configuration
>> only to those nodes that actually will be used for UART on one or
>> another device. Is this the case for all these UART nodes?
>
>Recently, we have begun adding all possible UART configurations, similar to what we’ve done with I2C and SPI.
>We will continue this approach for future targets.


Please describe why it is done, not what is being done by the patch. In other words, why do you need all uarts in this case.


>
>> 
>>> 
>>> Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
>>> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
>>> Signed-off-by: Viken Dadhaniya <quic_vdadhani@xxxxxxxxxxx>
>>> ---
>>> v1 -> v2:
>>> 
>>> - Modifed commit log as requested by Krzysztof.
>>> - Added co-developed-by tag.
>>> 
>>> v1 Link: https://lore.kernel.org/linux-arm-msm/98e7dc28-4413-4247-bad1-98b529f6d62d@xxxxxxxxxx/T/
>>> ---
>>> ---
>>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 231 ++++++++++++++++++++++++++
>>>   1 file changed, 231 insertions(+)
>>> 
>> 


-- 
With best wishes
Dmitry