Re: [PATCH] sched: Fix typo of head comment of ___update_load_avg

From: Peter Zijlstra
Date: Mon Oct 07 2024 - 04:10:29 EST


On Mon, Oct 07, 2024 at 08:42:14AM +0200, Vincent Guittot wrote:
> On Sat, 5 Oct 2024 at 02:53, Zhouyi Zhou <zhouzhouyi@xxxxxxxxx> wrote:
> >
> > The head comment of ___update_load_avg illustrates the principle of
> > PELT divider. "unwanted oscillation in the range [1002..1024[" should
> > be "unwanted oscillation in the range [1002..1024]".
> >
> > Fix above typo.
>
> This is not a typo as 1024 is an excluded endpoint of the interval.
> Some may use [1002..1024) but both [1002..1024[ and [1002..1024) can
> be used

Because I'm weird, I googled this, and the [a,b[ notation is from
Bourbaki and hence popular in the French speaking world :-)

We don't have many intervals specified in comments and hence we can't
make the inconsistent style argument either.

So yeah, let it be.. at best its a trigger to get people to better look
at the code. At worst its one of those triggers that people keep trying
to mindlessly 'fix', like my use of borken :-)