Re: [PATCH v2 2/3] dt-bindings: mmc: document mmc-slot

[Neil Armstrong]

Hi,

On 24/09/2024 11:15, Krzysztof Kozlowski wrote:
> On Fri, Sep 20, 2024 at 10:38:04AM +0200, Neil Armstrong wrote:
> > Document the mmc-slot, which is a subnode of a multi-slot
> > MMC controlle, each slot is represented as a full MMC controller,
>
> typo: controller
>
> > the top node handling all the shared resources and slot mux.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/mmc/mmc-slot.yaml          | 40 ++++++++++++++++++++++
> >   1 file changed, 40 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mmc-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-slot.yaml
> > new file mode 100644
> > index 000000000000..c30eda4fd2a6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/mmc-slot.yaml
> > @@ -0,0 +1,40 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mmc/mmc-slot.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MMC/SD/SDIO slot of a multi-slot controller
> > +
> > +maintainers:
> > +  - Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> > +
>
> description here saying what is the MMC slot, e.g. what you wrote in
> commit msg.

Right will fix the description, bad copy paste

> > +allOf:
> > +  - $ref: mmc-controller.yaml
> > +
>
> Just to be sure - the slots do not have dedicated resources like clocks,
> resets, power supplies, right? IOW, it is indeed one device which
> exposes multiple controllers?

Yes exact, resources are common to the slots

> > +properties:
> > +  compatible:
> > +    const: mmc-slot
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +unevaluatedProperties: false
>
> Best regards,
> Krzysztof