Re: [PATCH net-next 6/9] net: phy: mediatek: Hook LED helper functions in mtk-ge.c

[SkyLake Huang (黃啟澤)]

On Sun, 2024-10-06 at 23:32 +0200, Andrew Lunn wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  > +static int mt753x_phy_led_blink_set(struct phy_device *phydev, u8
> index,
> > +    unsigned long *delay_on,
> > +    unsigned long *delay_off)
> > +{
> > +struct mtk_gephy_priv *priv = phydev->priv;
> > +bool blinking = false;
> > +int err = 0;
> 
> There is no need to set err.
> 
> > +
> > +err = mtk_phy_led_num_dly_cfg(index, delay_on, delay_off,
> &blinking);
> > +if (err < 0)
> > +return err;
> 
> 
>     Andrew
> 
> ---
> pw-bot: cr

I'll fix this in next version. Thx!

BRs,
Sky