Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h

From: Vincenzo Frascino
Date: Mon Oct 07 2024 - 07:20:36 EST




On 07/10/2024 12:06, Arnd Bergmann wrote:
> On Mon, Oct 7, 2024, at 11:01, Vincenzo Frascino wrote:
>> On 04/10/2024 14:13, Arnd Bergmann wrote:
>
>>
>> It seemed harmless from the tests I did. But adding an '&&
>> defined(CONFIG_32BIT)' makes it logically correct. I will add a comment as well
>> in the next version.
>
> To clarify: this has to be "!defined(CONFIG_64BIT)", as most
> 32-bit architectures don't define the CONFIG_32BIT symbol
> (but all 64-bit ones define CONFIG_64BIT).
>

You are right, it seemed that every 32-bit architectures with a
64-bit phys_addr_t had CONFIG_32BIT but this is not the case.

> Arnd

--
Regards,
Vincenzo