Re: [PATCH] netfs: In readahead, put the folio refs as soon extracted

From: Christian Brauner
Date: Mon Oct 07 2024 - 07:49:00 EST


On Fri, 04 Oct 2024 15:33:58 +0100, David Howells wrote:
> netfslib currently defers dropping the ref on the folios it obtains during
> readahead to after it has started I/O on the basis that we can do it whilst
> we wait for the I/O to complete, but this runs the risk of the I/O
> collection racing with this in future.
>
> Furthermore, Matthew Wilcox strongly suggests that the refs should be
> dropped immediately, as readahead_folio() does (netfslib is using
> __readahead_batch() which doesn't drop the refs).
>
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] netfs: In readahead, put the folio refs as soon extracted
https://git.kernel.org/vfs/vfs/c/796a4049640b