Re: [PATCH 1/2] arm64: dts: renesas: salvator-xs: Add SD/OE pin properties

From: Geert Uytterhoeven
Date: Mon Oct 07 2024 - 08:14:39 EST


On Fri, Sep 27, 2024 at 12:34 PM Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Thu, Sep 26, 2024 at 8:09 PM Sean Anderson <sean.anderson@xxxxxxxxx> wrote:
> > Add SD/OE pin properties to the devicetree so that Linux can configure
> > the pin without relying on the OTP. This matches the register
> > configuration reported by Geert [1], as well as my inspection of the
> > schematic (which shows the SD/OE pin permanently tied high).
> >
> > [1] https://lore.kernel.org/linux-clk/CAMuHMdW9LMuQLuPEF-Fcs1E6Q7dDzY17VZqu4awKDj5WSTRt=A@xxxxxxxxxxxxxx/
> >
> > Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxxx>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> There is no change in the output of
>
> grep 10: /sys/kernel/debug/regmap/*-006a/registers
>
> before/after this patch, so
> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> BTW, I applied the same patch to salvator-x.dtsi, and that seems to be
> fine, too.

Thanks, will queue in renesas-devel for v6.13.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds