Re: [PATCH net-next 3/9] net: phy: mediatek: Move LED helper functions into mtk phy lib
From: Andrew Lunn
Date: Mon Oct 07 2024 - 08:51:05 EST
> Although this is just "moving code", we need this priv to do some
> modification for mt798x_phy_hw_led_blink_set() so that we can move it
> to mtk-phy-lib properly.
The helper is passed phydev, so it is not clear to me why the helper
cannot do:
struct mtk_socphy_priv *priv = phydev->priv;
same as the old code. Maybe you want a patch first which renames
mtk_socphy_priv to mtk_phy_priv, just to keep with the naming?
Or do you see the need for different PHYs to need different priv
structures?
Andrew