Re: [PATCH v1 0/4] Add invokeV2 to support new features

From: Dmitry Baryshkov
Date: Mon Oct 07 2024 - 09:27:28 EST


On Mon, Oct 07, 2024 at 02:15:14PM GMT, Ekansh Gupta wrote:
> This patch series adds the listed features that have been missing
> in upstream fastRPC driver.

please use sensible subject for the cover letter too. Ideally it should
start with the corresponding subsys name or otherwise point out the
target.

>
> - Add changes to support new enhanced invocation ioctl request.
> - Add support for CRC check.
> - Add support for DSP and kernel performance counters.
> - Add polling mode support.
>
> Userspace change: https://github.com/quic/fastrpc/pull/73

Up to now we have been using [1]. There is no way to switch to the
mentioned repo with no changelog information between them.

And anyway, as pointed out earlier, please steer your activities towards
implementation at [2]. Both "fastrpc" implementation are ugly,
AOSP-centric and must be dropped as soon as possible.

[1] https://git.codelinaro.org/linaro/qcomlt/fastrpc.git
[2] https://github.com/linux-msm/hexagonrpc

>
> Ekansh Gupta (4):
> misc: fastrpc: Add CRC support using invokeV2 request
> misc: fastrpc: Capture kernel and DSP performance counters
> misc: fastrpc: Modify context id calculation for poll mode
> misc: fastrpc: Add polling mode support for fastRPC driver
>
> drivers/misc/fastrpc.c | 435 ++++++++++++++++++++++++++++++------
> include/uapi/misc/fastrpc.h | 10 +
> 2 files changed, 376 insertions(+), 69 deletions(-)
>
> --
> 2.34.1
>

--
With best wishes
Dmitry