Re: [PATCH] rpmsg: glink: use only lower 16-bits of param2 for CMD_OPEN name length

From: Dmitry Baryshkov
Date: Mon Oct 07 2024 - 10:01:33 EST


On Mon, Oct 07, 2024 at 09:19:05AM GMT, Jonathan Marek wrote:
> On 10/7/24 9:16 AM, Dmitry Baryshkov wrote:
> > On Mon, Oct 07, 2024 at 12:47:22AM GMT, Jonathan Marek wrote:
> > > The name len field of the CMD_OPEN packet is only 16-bits and the upper
> > > 16-bits of "param2" are a different field, which can be nonzero in certain
> > > situations, and CMD_OPEN packets can be unexpectedly dropped because of
> > > this.
> >
> > Any idea about the upper 16 bits? Should we care about that data too?
> >
>
> Its a "prio" value, it should be OK to ignore it.

Could you please document it in the commit message and in a comment next
to the qcom_glink_rx_defer() call?

--
With best wishes
Dmitry