Re: [PATCH] KVM: selftests: memslot_perf_test: increase guest sync timeout

[Liam Merwick]

On 04/10/2024 23:01, Maxim Levitsky wrote:
> When memslot_perf_test is run nested, first iteration of test_memslot_rw_loop
> testcase, sometimes takes more than 2 seconds due to build of shadow page tables.
> 
> Following iterations are fast.
> 
> To be on the safe side, bump the timeout to 10 seconds.
> 
> Signed-off-by: Maxim Levitsky <mlevitsk@xxxxxxxxxx>

I see the issue without this fix.

Tested-by: Liam Merwick <liam.merwick@xxxxxxxxxx>
Reviewed-by: Liam Merwick <liam.merwick@xxxxxxxxxx>


> ---
>   tools/testing/selftests/kvm/memslot_perf_test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/memslot_perf_test.c b/tools/testing/selftests/kvm/memslot_perf_test.c
> index 893366982f77b..e9189cbed4bb6 100644
> --- a/tools/testing/selftests/kvm/memslot_perf_test.c
> +++ b/tools/testing/selftests/kvm/memslot_perf_test.c
> @@ -415,7 +415,7 @@ static bool _guest_should_exit(void)
>    */
>   static noinline void host_perform_sync(struct sync_area *sync)
>   {
> -	alarm(2);
> +	alarm(10);
>   
>   	atomic_store_explicit(&sync->sync_flag, true, memory_order_release);
>   	while (atomic_load_explicit(&sync->sync_flag, memory_order_acquire))