Re: Aw: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988

From: Matthias Brugger
Date: Mon Oct 07 2024 - 10:17:08 EST




On 06/10/2024 17:11, Frank Wunderlich wrote:
Hi

Gesendet: Sonntag, 06. Oktober 2024 um 14:48 Uhr
Von: "Krzysztof Kozlowski" <krzk@xxxxxxxxxx>
Betreff: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988

On Sun, Oct 06, 2024 at 12:27:39PM +0200, Frank Wunderlich wrote:
From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>

MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single
and mediatek,ipm-spi-quad compatibles.

Why generic compatibles?

These are supposed to be SoC-specific.

currently i used the compatibles used in SDK, but got info now, that there is some more discussion needed with mtk.


Ok, but please don't introduce generic compatibles. We prever SoC specific ones with a fall-back (to a different SoC specific one).

Regards,
Matthias