Re: [PATCH V22 00/22] Add support UHS-II for GL9755 and GL9767

From: Ulf Hansson
Date: Mon Oct 07 2024 - 11:34:53 EST


On Fri, 13 Sept 2024 at 12:28, Victor Shih <victorshihgli@xxxxxxxxx> wrote:
>
> From: Victor Shih <victor.shih@xxxxxxxxxxxxxxxxxxx>
>
> Summary
> =======
> These patches[1] support UHS-II and fix GL9755 and GL9767
> UHS-II compatibility.
>
> About UHS-II, roughly deal with the following three parts:
> 1) A UHS-II detection and initialization:
> - Host setup to support UHS-II (Section 3.13.1 Host Controller Setup
> Sequence[2]).
> - Detect a UHS-II I/F (Section 3.13.2 Card Interface Detection Sequence
> [2]).
> - In step(9) of Section 3.13.2 in [2], UHS-II initialization is include
> Section 3.13.3 UHS-II Card Initialization and Section 3.13.4 UHS-II
> Setting Register Setup Sequence.
>
> 2) Send Legacy SD command through SD-TRAN
> - Encapsulated SD packets are defined in SD-TRAN in order to ensure Legacy
> SD compatibility and preserve Legacy SD infrastructures (Section 7.1.1
> Packet Types and Format Overview[3]).
> - Host issue a UHS-II CCMD packet or a UHS-II DCMD (Section 3.13.5 UHS-II
> CCMD Packet issuing and Section 3.13.6 UHS-II DCMD Packet issuing[2]).
>
> 3) UHS-II Interrupt
> - Except for UHS-II error interrupts, most interrupts share the original
> interrupt registers.
>
> Patch structure
> ===============
> patch#1-#7: for core
> patch#8-#20: for sdhci
> patch#21: for GL9755
> patch#22: for GL9767

Patch 1 -> 6 applied for next, with some minor updates to patch2.

Patch 7 needs some more work, I will comment on that separately.

I am okay with patch 8 -> 22, but since there will be a re-spin for a
new version, perhaps you can run a new round of checkpatch.pl to see
if some of the warning that it reports can be fixed too.

[...]

Kind regards
Uffe