Re: [PATCH v3 0/3] Improve error handling in Rockchip Inno USB 2.0 PHY driver
From: Vinod Koul
Date: Mon Oct 07 2024 - 11:49:37 EST
On Thu, 05 Sep 2024 10:28:21 +0200, Dragan Simic wrote:
> This is a small series that improves error handling in the probe path
> of the Rockchip Innosilicon USB 2.0 PHY driver, by returning the actual
> error code in one place and by using dev_err_probe() properly in multiple
> places. It also performs a bunch of small, rather trivial code cleanups,
> to make the code neater and a bit easier to read.
>
> Changes in v3:
> - Collected Reviewed-by tags from Heiko for patches 1/3 and 2/3
> - Brought back one empty line as a separator of dissimilar operations
> in patch 1/3, as suggested by Heiko [2]
> - Dropped one backward conversion of dev_err_probe() to dev_err() in
> patch 3/3, as suggested by Heiko, [3] and adjusted the summary and
> description of patch 3/3 accordingly
>
> [...]
Applied, thanks!
[1/3] phy: phy-rockchip-inno-usb2: Perform trivial code cleanups
commit: 449d2a523a0c3ca8f4c993b8e37795c2aa174da6
[2/3] phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better
commit: 595ad7a336bf21f9d111a033820cd95d70343bd1
[3/3] phy: phy-rockchip-inno-usb2: Use dev_err_probe() in the probe path
commit: 40452520850683f6771094ca218ff206d1fcb022
Best regards,
--
~Vinod