Re: [PATCH v2 0/6] Enhance union-find with KUnit tests and optimization improvements

From: Tejun Heo
Date: Mon Oct 07 2024 - 12:19:18 EST


Hello,

On Mon, Oct 07, 2024 at 11:28:27PM +0800, Kuan-Wei Chiu wrote:
> This patch series adds KUnit tests for the union-find implementation
> and optimizes the path compression in the uf_find() function to achieve
> a lower tree height and improved efficiency. Additionally, it modifies
> uf_union() to return a boolean value indicating whether a merge
> occurred, enhancing the process of calculating the number of groups in
> the cgroup cpuset.

I'm not necessarily against the patchset but this probably is becoming too
much polishing for something which is only used by cpuset in a pretty cold
path. It probably would be a good idea to concentrate on finding more use
cases.

Thanks.

--
tejun