Re: [PATCH v1 1/3] drm/ci: refactor software-driver stage jobs
From: Daniel Stone
Date: Mon Oct 07 2024 - 12:39:39 EST
Hi Vignesh,
On Fri, 4 Oct 2024 at 09:31, Vignesh Raman <vignesh.raman@xxxxxxxxxxxxx> wrote:
> +.software-driver:
> + stage: software-driver
> + extends:
> + - .test-gl
> + - .test-rules
> + timeout: "1h30m"
> + tags:
> + - kvm
> + script:
> + - ln -sf $CI_PROJECT_DIR/install /install
> + - mv install/bzImage /lava-files/bzImage
> + - mkdir -p /lib/modules
> + - mkdir -p $CI_PROJECT_DIR/results
> + - ln -sf $CI_PROJECT_DIR/results /results
> + - install/crosvm-runner.sh install/igt_runner.sh
Instead of inlining this here, can we please move towards reusing more
of .gitlab-ci/common/init-stage[12].sh? If those files need to be
modified then that's totally fine, but I'd rather have something more
predictable, and fewer random pieces of shell in each job section.