Re: [syzbot] [hfs?] general protection fault in hfs_mdb_commit

[Eric Sandeen]

On 10/5/24 5:51 AM, syzbot wrote:
> syzbot has bisected this issue to:
> 
> commit c87d1f1aa91c2e54234672c728e0e117d2bff756
> Author: Eric Sandeen <sandeen@xxxxxxxxxx>
> Date:   Mon Sep 16 17:26:21 2024 +0000
> 
>     hfs: convert hfs to use the new mount api
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=17b2bbd0580000
> start commit:   c02d24a5af66 Add linux-next specific files for 20241003
> git tree:       linux-next
> final oops:     https://syzkaller.appspot.com/x/report.txt?x=1472bbd0580000
> console output: https://syzkaller.appspot.com/x/log.txt?x=1072bbd0580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=94f9caf16c0af42d
> dashboard link: https://syzkaller.appspot.com/bug?extid=5cfa9ffce7cc5744fe24
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=114be307980000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=16bef527980000
> 
> Reported-by: syzbot+5cfa9ffce7cc5744fe24@xxxxxxxxxxxxxxxxxxxxxxxxx
> Fixes: c87d1f1aa91c ("hfs: convert hfs to use the new mount api")
> 
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

#syz test 

diff --git a/fs/hfs/super.c b/fs/hfs/super.c
index ee314f3e39f8..3bee9b5dba5e 100644
--- a/fs/hfs/super.c
+++ b/fs/hfs/super.c
@@ -328,6 +328,7 @@ static int hfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	spin_lock_init(&sbi->work_lock);
 	INIT_DELAYED_WORK(&sbi->mdb_work, flush_mdb);
 
+	sbi->sb = sb;
 	sb->s_op = &hfs_super_operations;
 	sb->s_xattr = hfs_xattr_handlers;
 	sb->s_flags |= SB_NODIRATIME;