Re: [PATCH v1 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

[Doug Anderson]

Hi,

On Mon, Oct 7, 2024 at 1:14 PM Aleksandrs Vinarskis
<alex.vinarskis@xxxxxxxxx> wrote:
>
> Introduce low-res IPS and OLED panels for mentioned device.
>
> SHP panel's timings were picked experimentally, without this patch or with
> `delay_200_500_e50` panel sometimes fails to boot/stays black on startup.
>
> LGD panel's timings were copied from other LGD panels and tested to be
> working.
>
> Particular laptop also comes in high-res IPS variant, which unfortunately
> I do not have access to verify.
>
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx>
> Tested-by: Peter de Kraker <peterdekraker@xxxxxxxx>

Your signed-off-by should be _below_ Peter's Tested-by. That means
that you're the one that signed-off on the fact that Peter tested
this.

> ---
>  drivers/gpu/drm/panel/panel-edp.c | 2 ++
>  1 file changed, 2 insertions(+)

This looks OK to me. I've been requesting people include the RAW EDID
of panels that they add in the commit message, though. Could you do
that and send a v2? Also: note that since I didn't see Peter provide
his Tested-by himself, I'd probably wait a little longer before
landing to give him a chance to object.

-Doug