Re: [PATCH v2] i3c: master: svc: Fix pm_runtime_set_suspended() with runtime pm enabled
From: Jinjie Ruan
Date: Mon Oct 07 2024 - 22:34:14 EST
Ping.
On 2024/9/30 17:19, Jinjie Ruan wrote:
> It is not valid to call pm_runtime_set_suspended() for devices
> with runtime PM enabled because it returns -EAGAIN if it is enabled
> already and working. So, call pm_runtime_disable() before to fix it.
>
> Cc: stable@xxxxxxxxxxxxxxx # v5.17
> Fixes: 05be23ef78f7 ("i3c: master: svc: add runtime pm support")
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
> ---
> v2:
> - Add Reviewed-by.
> - Add stable tag as Miquel suggested.
> ---
> drivers/i3c/master/svc-i3c-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index a7bfc678153e..130cec4ee307 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1827,8 +1827,8 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
> rpm_disable:
> pm_runtime_dont_use_autosuspend(&pdev->dev);
> pm_runtime_put_noidle(&pdev->dev);
> - pm_runtime_set_suspended(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> + pm_runtime_set_suspended(&pdev->dev);
>
> err_disable_clks:
> svc_i3c_master_unprepare_clks(master);