Re: [PATCH v2] rpmsg: glink: use only lower 16-bits of param2 for CMD_OPEN name length

From: Dmitry Baryshkov
Date: Mon Oct 07 2024 - 23:55:00 EST


On Mon, Oct 07, 2024 at 07:59:35PM GMT, Jonathan Marek wrote:
> The name len field of the CMD_OPEN packet is only 16-bits and the upper
> 16-bits of "param2" are a different "prio" field, which can be nonzero in
> certain situations, and CMD_OPEN packets can be unexpectedly dropped
> because of this.
>
> Fix this by masking out the upper 16 bits of param2.
>
> Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver")
> Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>
> ---
> drivers/rpmsg/qcom_glink_native.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

--
With best wishes
Dmitry