Re: [PATCH V4 0/5] arm_scmi: vendors: Qualcomm Generic Vendor Extensions

From: Krzysztof Kozlowski
Date: Tue Oct 08 2024 - 03:34:58 EST


On Mon, Oct 07, 2024 at 11:40:18AM +0530, Sibi Sankar wrote:
> The QCOM SCMI vendor protocol provides a generic way of exposing a
> number of Qualcomm SoC specific features (like memory bus scaling)
> through a mixture of pre-determined algorithm strings and param_id
> pairs hosted on the SCMI controller. Introduce a client driver that
> uses the memlat algorithm string hosted on QCOM SCMI Vendor Protocol
> to detect memory latency workloads and control frequency/level of
> the various memory buses (DDR/LLCC/DDR_QOS).

None of your patches are wrapped according to Linux coding style which
makes reviewing more difficult than it should be. And before you answer
with checkpatch, checkpatch is not a coding style.

Best regards,
Krzysztof