Re: [PATCH] drivers/applicom:Removed the unused variable byte_reset_it
From: Arnd Bergmann
Date: Tue Oct 08 2024 - 04:20:47 EST
On Tue, Oct 8, 2024, at 07:28, Zhu Jun wrote:
> Remove unused variable and redundant readb in ac_register_board
>
> Signed-off-by: Zhu Jun <zhujun2@xxxxxxxxxxxxxxxxxxxx>
This is probably intentional, as the readb() can both have side-effects
on the device and serialize the device against a previous instructions.
It would have been nice to have a comment in there, but since that
is 30 year old code, I doubt we get more information on it now.
Just don't remove those.
Arnd