Re: [PATCH 1/1] s390/virtio_ccw: fix dma_parm pointer not set up

[Marc Hartmayer]

On Mon, Oct 07, 2024 at 10:10 PM +0200, Halil Pasic <pasic@xxxxxxxxxxxxx> wrote:
> At least since commit 334304ac2bac ("dma-mapping: don't return errors
> from dma_set_max_seg_size") setting up device.dma_parms is basically
> mandated by the DMA API. As of now Channel (CCW) I/O in general does not
> utilize the DMA API, except for virtio. For virtio-ccw however the
> common virtio DMA infrastructure is such that most of the DMA stuff
> hinges on the virtio parent device, which is a CCW device.
>
> So lets set up the dma_parms pointer for the CCW parent device and hope
> for the best!
>
> Signed-off-by: Halil Pasic <pasic@xxxxxxxxxxxxx>
> Fixes: 334304ac2bac ("dma-mapping: don't return errors from dma_set_max_seg_size")
> Reported-by: "Marc Hartmayer" <mhartmay@xxxxxxxxxxxxx>
> Closes: https://bugzilla.linux.ibm.com/show_bug.cgi?id=209131

I guess, this line can be removed as it’s internal only.

> Reviewed-by: Eric Farman <farman@xxxxxxxxxxxxx>
> ---
>
> In the long run it may make sense to move dma_parms into struct
> ccw_device, since layering-wise it is much cleaner. I decided
> to put it in virtio_ccw_device because currently it is only used for
> virtio.
>
> ---

[…snip…]

Thanks for fixing this!

Tested-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx>

-- 
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294