Re: [PATCH v3] SLUB: Add support for per object memory policies

[Vlastimil Babka]

On 10/6/24 16:37, Hyeonggon Yoo wrote:

>> +
>>         if (!USE_LOCKLESS_FAST_PATH() ||
>>             unlikely(!object || !slab || !node_match(slab, node))) {
>>                 object = __slab_alloc(s, gfpflags, node, addr, c, orig_size);
>> @@ -5601,6 +5627,22 @@ static int __init setup_slub_min_objects(char *str)
>>  __setup("slab_min_objects=", setup_slub_min_objects);
>>  __setup_param("slub_min_objects=", slub_min_objects, setup_slub_min_objects, 0);
>>
>> +#ifdef CONFIG_NUMA
>> +static int __init setup_slab_strict_numa(char *str)
>> +{
>> +       if (nr_node_ids > 1) {
>> +               static_branch_enable(&strict_numa);
>> +               pr_info("SLUB: Strict NUMA enabled.\n");
>> +       } else
>> +               pr_warn("slab_strict_numa parameter set on non NUMA system.\n");
> 
> nit: this statement should be enclosed within braces per coding style guideline.
> Otherwise everything looks good to me (including the document amended).

Right, amended locally, thanks.

> Best,
> Hyeonggon