Re: [PATCH 6.1.y 1/5] erofs: get rid of erofs_inode_datablocks()

[Gao Xiang]

On 2024/10/8 18:26, Greg Kroah-Hartman wrote:
> On Tue, Oct 08, 2024 at 02:57:04PM +0800, Gao Xiang wrote:
> > commit 4efdec36dc9907628e590a68193d6d8e5e74d032 upstream.
> >
> > erofs_inode_datablocks() has the only one caller, let's just get
> > rid of it entirely.  No logic changes.
> >
> > Reviewed-by: Yue Hu <huyue2@xxxxxxxxxxx>
> > Reviewed-by: Jingbo Xu <jefflexu@xxxxxxxxxxxxxxxxx>
> > Reviewed-by: Chao Yu <chao@xxxxxxxxxx>
> > Stable-dep-of: 9ed50b8231e3 ("erofs: fix incorrect symlink detection in fast symlink")
> > Link: https://lore.kernel.org/r/20230204093040.97967-1-hsiangkao@xxxxxxxxxxxxxxxxx
> > [ Gao Xiang: apply this to 6.6.y to avoid further backport twists
> >               due to obsoleted EROFS_BLKSIZ. ]
> > Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>
> > ---
> > Obsoleted EROFS_BLKSIZ impedes efforts to backport
> >   9ed50b8231e3 ("erofs: fix incorrect symlink detection in fast symlink")
> >   9e2f9d34dd12 ("erofs: handle overlapped pclusters out of crafted images properly")
> >
> > To avoid further bugfix conflicts due to random EROFS_BLKSIZs
> > around the whole codebase, just backport the dependencies for 6.1.y.
>
> all now queued up, thanks.

Thanks Greg, I'd like to avoid obsoleted EROFS_BLKSIZ
conflicts for 6.1.y anymore (and just a few dependencies
to avoid this), so that will save the future bugfix
backport efforts around the 6.1.y codebase.

For more older stable versions, I will manually handle
conflicts later since more non-trivial dependencies need
otherwise but I think bugfixes for older stable versions
will become fewer and fewer...

Thanks,
Gao Xiang

> greg k-h