Re: [PATCH 1/2] fs/super.c: introduce get_tree_bdev_by_dev()

From: Christoph Hellwig
Date: Tue Oct 08 2024 - 08:24:29 EST


On Tue, Oct 08, 2024 at 08:10:45PM +0800, Gao Xiang wrote:
> But the error message out of get_tree_bdev() is inflexible and
> IMHO it's too coupled to `fc->source`.
>
> > Otherwise just passing a quiet flag of some form feels like a much
> > saner interface.
>
> I'm fine with this way, but that will be a treewide change, I
> will send out a version with a flag later.

I'd probably just add a get_tree_bdev_flags and pass 0 flags from
get_tree_bdev.