Re: [PATCH 1/2] fs/super.c: introduce get_tree_bdev_by_dev()

From: Christoph Hellwig
Date: Tue Oct 08 2024 - 08:57:32 EST


On Tue, Oct 08, 2024 at 08:33:27PM +0800, Gao Xiang wrote:
> how about
> int get_tree_bdev_flags(struct fs_context *fc,
> int (*fill_super)(struct super_block *,
> struct fs_context *), bool quiet)
>
> for now? it can be turned into `int flags` if other needs
> are shown later (and I don't need to define an enum.)

I'd pass an unsigned int flags with a clearly spellt out (and
extensible) flags namespae.