Re: [net-next PATCH v2] net: phy: Validate PHY LED OPs presence before registering

[Andrew Lunn]

> +	/* Check if the PHY driver have at least an OP to
> +	 * set the LEDs.
> +	 */
> +	if (!phydev->drv->led_brightness_set &&
> +	    !phydev->drv->led_blink_set &&
> +	    !phydev->drv->led_hw_control_set) {

I think this condition is too strong. All that should be required is
led_brightness_set(). The rest can be done in software.


    Andrew

---
pw-bot: cr