Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h

[Arnd Bergmann]

On Mon, Oct 7, 2024, at 16:23, Thomas Gleixner wrote:
> On Fri, Oct 04 2024 at 13:13, Arnd Bergmann wrote:
>> On Thu, Oct 3, 2024, at 15:29, Vincenzo Frascino wrote:
>>> The VDSO implementation includes headers from outside of the
>>> vdso/ namespace.
>>>
>>> Introduce vdso/page.h to make sure that the generic library
>>> uses only the allowed namespace.
>>>
>>> Note: on a 32-bit architecture UL is an unsigned 32 bit long. Hence when
>>> it supports 64-bit phys_addr_t we might end up in situation in which the
>>> top 32 bit are cleared. To prevent this issue this patch provides
>>> separate macros for PAGE_MASK.
>>>
>>> Cc: Arnd Bergmann <arnd@xxxxxxxx>
>>> Cc: Andy Lutomirski <luto@xxxxxxxxxx>
>>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>>> Cc: Jason A. Donenfeld <Jason@xxxxxxxxx>
>>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
>>
>> Looks good to me. I would apply this to the asm-generic
>> tree for 6.13, but there is one small detail I'm unsure
>> about:
>
> Please don't. We have related changes upcoming for VDSO which would
> heavily conflict. I rather take it through my tree.

Ok.

Vincenzo, in that case please add 

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

to the two paches when you send v4 to Thomas.

     Arnd