Re: [PATCH v3 4/5] driver core: Add device probe log helper dev_warn_probe()

From: Greg KH
Date: Tue Oct 08 2024 - 09:32:03 EST


On Mon, Oct 07, 2024 at 03:25:52PM +0100, Mark Brown wrote:
> On Sun, Sep 29, 2024 at 11:21:16AM +0200, Dragan Simic wrote:
> > Some drivers can still provide their functionality to a certain extent even
> > some of their resource acquisitions eventually fail. In such cases, emitting
> > errors isn't the desired action, but warnings should be emitted instead.
> >
> > To solve this, introduce dev_warn_probe() as a new device probe log helper,
> > which behaves identically as the already existing dev_err_probe(), while it
> > produces warnings instead of errors. The intended use is with the resources
> > that are actually optional for a particular driver.
> >
> > While there, copyedit the kerneldoc for dev_err_probe() a bit, to simplify
> > its wording a bit, and reuse it as the kerneldoc for dev_warn_probe(), with
> > the necessary wording adjustments, of course.
>
> Greg, this makes sense to me - are you OK with me applying it?

No objection from me, now sent a reviewed-by