Re: [PATCH v2 3/4] sched, psi: Don't account irq time if sched_clock_irqtime is disabled

From: Johannes Weiner
Date: Tue Oct 08 2024 - 10:04:57 EST


On Tue, Oct 08, 2024 at 02:19:50PM +0800, Yafang Shao wrote:
> sched_clock_irqtime may be disabled due to the clock source, in which case
> IRQ time should not be accounted. Let's add a conditional check to avoid
> unnecessary logic.

Makes sense. When disabled, irq_time_read() won't change over time, so
there is nothing to account. We can save iterating the whole hierarchy
on every tick and context switch.

> Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>