Re: [PATCH net-next v5 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit()

[Menglong Dong]

On Tue, Oct 8, 2024 at 8:28 PM Simon Horman <horms@xxxxxxxxxx> wrote:
>
> On Sun, Oct 06, 2024 at 02:56:12PM +0800, Menglong Dong wrote:
> > Replace kfree_skb() with kfree_skb_reason() in vxlan_xmit(). Following
> > new skb drop reasons are introduced for vxlan:
> >
> > /* no remote found for xmit */
> > SKB_DROP_REASON_VXLAN_NO_REMOTE
> > /* packet without necessary metatdata reached a device is in "eternal"
> >  * mode.
> >  */
> > SKB_DROP_REASON_TUNNEL_TXINFO
>
> nit: metadata
>
>      Flagged by checkpatch.pl --codespell
>
> >
> > Signed-off-by: Menglong Dong <dongml2@xxxxxxxxxxxxxxx>
> > Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
>
> ...
>
> > diff --git a/include/net/dropreason-core.h b/include/net/dropreason-core.h
>
> ...
>
> > @@ -439,11 +441,17 @@ enum skb_drop_reason {
> >        * entry or an entry pointing to a nexthop.
> >        */
> >       SKB_DROP_REASON_VXLAN_ENTRY_EXISTS,
> > +     /** @SKB_DROP_REASON_VXLAN_NO_REMOTE: no remote found for xmit */
> > +     SKB_DROP_REASON_VXLAN_NO_REMOTE,
> >       /**
> >        * @SKB_DROP_REASON_IP_TUNNEL_ECN: skb is dropped according to
> >        * RFC 6040 4.2, see __INET_ECN_decapsulate() for detail.
> >        */
> >       SKB_DROP_REASON_IP_TUNNEL_ECN,
> > +     /** @SKB_DROP_REASON_TUNNEL_TXINFO: packet without necessary metatdata
> > +      * reached a device is in "eternal" mode.
> > +      */
> > +     SKB_DROP_REASON_TUNNEL_TXINFO,
>
> nit: ./scripts/kernel-doc would like this to be formatted as follows.
>      And metadata is misspelt.
>

Hello, thanks for reminding me. It seems that there is no
more comment on this series, and I'll send a V6 now to
fix this problem.

Thanks!
Menglong Dong

>         /**
>          * @SKB_DROP_REASON_TUNNEL_TXINFO: packet without necessary metadata
>          * reached a device is in "eternal" mode.
>          */
>         SKB_DROP_REASON_TUNNEL_TXINFO,
>
> >       /**
> >        * @SKB_DROP_REASON_LOCAL_MAC: the source MAC address is equal to
> >        * the MAC address of the local netdev.
> > --
> > 2.39.5
> >