Re: [PATCH 00/15] media: stm32: introduction of CSI / DCMIPP for STM32MP25

From: Rob Herring (Arm)
Date: Tue Oct 08 2024 - 10:57:09 EST


On Tue, 08 Oct 2024 13:18:02 +0200, Alain Volmat wrote:
> This series introduces the camera pipeline support for the
> STM32MP25 SOC. The STM32MP25 has 3 pipelines, fed from a
> single camera input which can be either parallel or csi.
>
> This series adds the basic support for the 1st pipe (dump)
> which, in term of features is same as the one featured on
> the STM32MP13 SOC. It focuses on introduction of the
> CSI input stage for the DCMIPP, and the CSI specific new
> control code for the DCMIPP.
> One of the subdev of the DCMIPP, dcmipp_parallel is now
> renamed as dcmipp_input since it allows to not only control
> the parallel but also the csi interface.
>
> Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
> ---
> Alain Volmat (15):
> media: stm32: dcmipp: correct dma_set_mask_and_coherent mask value
> dt-bindings: media: addition of stm32 csi driver description
> media: stm32: csi: addition of the STM32 CSI driver
> media: stm32: dcmipp: use v4l2_subdev_is_streaming
> media: stm32: dcmipp: replace s_stream with enable/disable_streams
> media: stm32: dcmipp: rename dcmipp_parallel into dcmipp_input
> media: stm32: dcmipp: add support for csi input into dcmipp-input
> media: stm32: dcmipp: add bayer 10~14 bits formats
> media: stm32: dcmipp: add 1X16 RGB / YUV formats support
> media: stm32: dcmipp: avoid duplicated format on enum in bytecap
> media: stm32: dcmipp: fill media ctl hw_revision field
> dt-bindings: media: addition of stm32mp25 compatible of DCMIPP
> media: stm32: dcmipp: add core support for the stm32mp25
> arm64: dts: st: add csi & dcmipp node in stm32mp25
> arm64: dts: st: enable imx335/csi/dcmipp pipeline on stm32mp257f-ev1
>
> .../devicetree/bindings/media/st,stm32-csi.yaml | 129 +++
> .../devicetree/bindings/media/st,stm32-dcmipp.yaml | 53 +-
> MAINTAINERS | 8 +
> arch/arm64/boot/dts/st/stm32mp251.dtsi | 23 +
> arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 87 ++
> drivers/media/platform/st/stm32/Kconfig | 14 +
> drivers/media/platform/st/stm32/Makefile | 1 +
> drivers/media/platform/st/stm32/stm32-csi.c | 1150 ++++++++++++++++++++
> .../media/platform/st/stm32/stm32-dcmipp/Makefile | 2 +-
> .../st/stm32/stm32-dcmipp/dcmipp-bytecap.c | 128 ++-
> .../st/stm32/stm32-dcmipp/dcmipp-byteproc.c | 119 +-
> .../platform/st/stm32/stm32-dcmipp/dcmipp-common.h | 4 +-
> .../platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 116 +-
> .../platform/st/stm32/stm32-dcmipp/dcmipp-input.c | 540 +++++++++
> .../st/stm32/stm32-dcmipp/dcmipp-parallel.c | 440 --------
> 15 files changed, 2238 insertions(+), 576 deletions(-)
> ---
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
> change-id: 20241007-csi_dcmipp_mp25-7779601f57da
>
> Best regards,
> --
> Alain Volmat <alain.volmat@xxxxxxxxxxx>
>
>
>


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y st/stm32mp257f-ev1.dtb' for 20241008-csi_dcmipp_mp25-v1-0-e3fd0ed54b31@xxxxxxxxxxx:

arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb: imx335@1a: 'powerdown-gpios' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/media/i2c/sony,imx335.yaml#
arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb: csi@48020000: ports:port@0:endpoint:data-lanes:0: 0 is not of type 'array'
from schema $id: http://devicetree.org/schemas/media/st,stm32-csi.yaml#
arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb: csi@48020000: ports:port@0:endpoint:data-lanes:1: 1 is not of type 'array'
from schema $id: http://devicetree.org/schemas/media/st,stm32-csi.yaml#