Re: [PATCH] selftests: make kselftest-clean remove libynl outputs

From: Mina Almasry
Date: Tue Oct 08 2024 - 13:37:56 EST


On Sat, Oct 5, 2024 at 2:56 PM Greg Thelen <gthelen@xxxxxxxxxx> wrote:
>
> Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
> for devmem TCP") kselftest-all creates additional outputs that
> kselftest-clean does not cleanup:
> $ make defconfig
> $ make kselftest-all
> $ make kselftest-clean
> $ git clean -ndxf | grep tools/net
> Would remove tools/net/ynl/lib/__pycache__/
> Would remove tools/net/ynl/lib/ynl.a
> Would remove tools/net/ynl/lib/ynl.d
> Would remove tools/net/ynl/lib/ynl.o
>
> Make kselftest-clean remove the newly added net/ynl outputs.
>
> Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP")

Probably moot since this is merged already (sorry for the delay), but
likely it's:

Fixes: 07c3cc51a085 ("tools: net: package libynl for use in selftests")

The referenced patch doesn't touch ynl.mk, but adds a dependency on it

> Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx>

Thank you Greg,

Reviewed-by: Mina Almasry <almasrymina@xxxxxxxxxx>



--
Thanks,
Mina