Re: [RFC 01/14] x86/apic: Add new driver for Secure AVIC

From: Borislav Petkov
Date: Tue Oct 08 2024 - 15:16:41 EST


On Fri, Sep 13, 2024 at 05:06:52PM +0530, Neeraj Upadhyay wrote:
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index cd44e120fe53..ec038be0a048 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -394,6 +394,7 @@ void do_boot_stage2_vc(struct pt_regs *regs, unsigned long exit_code)
> MSR_AMD64_SNP_VMSA_REG_PROT | \
> MSR_AMD64_SNP_RESERVED_BIT13 | \
> MSR_AMD64_SNP_RESERVED_BIT15 | \
> + MSR_AMD64_SNP_SECURE_AVIC_ENABLED | \
> MSR_AMD64_SNP_RESERVED_MASK)
>
> /*

Shouldn't this hunk be in the last patch of the series, after all the sAVIC
enablement has happened?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette