Re: [PATCH v3] selftests: sched_ext: Add sched_ext as proper selftest target

From: David Vernet
Date: Tue Oct 08 2024 - 16:38:56 EST


On Tue, Oct 08, 2024 at 05:35:18PM +0200, Björn Töpel wrote:
> From: Björn Töpel <bjorn@xxxxxxxxxxxx>
>
> The sched_ext selftests is missing proper cross-compilation support, a
> proper target entry, and out-of-tree build support.
>
> When building the kselftest suite, e.g.:
>
> make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- \
> TARGETS=sched_ext SKIP_TARGETS="" O=/output/foo \
> -C tools/testing/selftests install
>
> or:
>
> make ARCH=arm64 LLVM=1 TARGETS=sched_ext SKIP_TARGETS="" \
> O=/output/foo -C tools/testing/selftests install
>
> The expectation is that the sched_ext is included, cross-built, the
> correct toolchain is picked up, and placed into /output/foo.
>
> In contrast to the BPF selftests, the sched_ext suite does not use
> bpftool at test run-time, so it is sufficient to build bpftool for the
> build host only.
>
> Add ARCH, CROSS_COMPILE, OUTPUT, and TARGETS support to the sched_ext
> selftest. Also, remove some variables that were unused by the
> Makefile.
>
> Signed-off-by: Björn Töpel <bjorn@xxxxxxxxxxxx>

Thanks for the improvements!

Acked-by: David Vernet <void@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature