Re: [PATCH v4 RESEND] HID: corsair-void: Add Corsair Void headset family driver

From: Jiri Kosina
Date: Tue Oct 08 2024 - 18:16:01 EST


On Tue, 8 Oct 2024, Stuart wrote:

> > As we alreay have general CONFIG_HID_CORSAIR, I think it'd make sense for
> > this driver to be encapsulated under this config option as well (it'd also
> > follow the general practice of HID subsystem, that the drivers are divided
> > per vendor) -- i.e. link hid-corsair-void into the final hid-corsair.ko
> > whenever CONFIG_HID_CORSAIR is selected.
> >
> > Would you be willing to make that small change, and resubmit for final
> > merge?
>
> Sure that makes sense, but I'm not sure how to do that exactly. Is
> there an example anywhere?

Just do something like

obj-$(CONFIG_HID_CORSAIR) += hid-corsair.o hid-corsair-void.o

in the Makefile. There are a few HID drivers there doing exactly that.
hid-roccat is probably the biggest user of this :)

Thanks,

--
Jiri Kosina
SUSE Labs