[PATCH v3 1/3] pinctrl: th1520: Fix return value for unknown pin error

From: Drew Fustini
Date: Tue Oct 08 2024 - 21:17:56 EST


Fix th1520_pinctrl_dt_node_to_map() to set the return value before
jumping to free_configs when an unknown pin error occurs.

Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Closes: https://lore.kernel.org/r/202410022336.xyWlV0Tf-lkp@xxxxxxxxx/
Signed-off-by: Drew Fustini <dfustini@xxxxxxxxxxxxxxx>
---
drivers/pinctrl/pinctrl-th1520.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/pinctrl-th1520.c b/drivers/pinctrl/pinctrl-th1520.c
index 9331f4462480..265a75a78d5a 100644
--- a/drivers/pinctrl/pinctrl-th1520.c
+++ b/drivers/pinctrl/pinctrl-th1520.c
@@ -499,6 +499,7 @@ static int th1520_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
nmaps = rollback;
dev_err(thp->pctl->dev, "%pOFn.%pOFn: unknown pin '%s'\n",
np, child, pinname);
+ ret = -EINVAL;
goto free_configs;
}


--
2.34.1