Re: [PATCH v6 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574

From: Manikanta Mylavarapu
Date: Wed Oct 09 2024 - 03:40:38 EST




On 10/7/2024 1:32 AM, Dmitry Baryshkov wrote:
> On Fri, Oct 04, 2024 at 01:33:30PM GMT, Manikanta Mylavarapu wrote:
>> From: Devi Priya <quic_devipriy@xxxxxxxxxxx>
>>
>> Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based
>> devices.
>>
>> Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
>> ---
>> Changes in V6:
>> - Remove 'nsscc_ipq9574_desc' and use 'nss_cc_ipq9574_desc' in
>> probe()
>> - Drop of_clk_get() and clk_prepare_enable() in probe() because
>> ethernet node will subscribe to GCC_NSSCC_CLK and enable it.
>
> Does the cllock supply the clock controller? If not, it should be
> dropped from bindings too.
>
Hi Dmitry,

Since GCC_NSSCC_CLK is the source for the NSS clock controller, there is no need to drop it from the bindings.

Thanks & Regards,
Manikanta.