Re: [PATCH 1/2] nvme: make independent ns identify default

From: Christoph Hellwig
Date: Wed Oct 09 2024 - 03:46:24 EST


On Tue, Oct 08, 2024 at 04:55:02PM +0200, Matias Bjørling wrote:
> However, the independent namespace data structure
> is mandatory for devices that implement features from the 2.0+
> specification. Therefore, we can check this data structure first. If
> unavailable, retrieve the generic attributes from the NVM command set
> identify namespace data structure.

I'm not a huge fan of this. For pre-2.0 controllers this means
we'll now send a command that will fail most of them time. And for
all the cheap low-end consumer device I'm actually worried that they'll
get it wrong and break something.